feat: Support multiple active CAs in tctl auth export#51298
Merged
codingllama merged 5 commits intomasterfrom Jan 22, 2025
Merged
feat: Support multiple active CAs in tctl auth export#51298codingllama merged 5 commits intomasterfrom
tctl auth export#51298codingllama merged 5 commits intomasterfrom
Conversation
creack
approved these changes
Jan 21, 2025
GavinFrazar
approved these changes
Jan 21, 2025
Contributor
GavinFrazar
left a comment
GavinFrazar
left a comment
There was a problem hiding this comment.
LGTM, I left a couple of suggestions.
Thanks for fixing this!
Contributor
Author
|
Many thanks for the quick reviews! I'll queue once the base PR is in. |
Contributor
Author
|
Friendly ping @avatus for g1 approval? |
avatus
approved these changes
Jan 22, 2025
codingllama
force-pushed
the
codingllama/export-all-tctl
branch
from
3952448 to
492ba3d
Compare
Contributor
Author
|
Rebased on top of master, no changes. I'll prep some prereq backports then merge this one. |
|
@codingllama See the table below for backport results.
|
This was referenced Jan 22, 2025
codingllama
added a commit
that referenced
this pull request
Jan 22, 2025
* Support multiple active CAs in `tctl auth export` * Remove the ExportAuthoritiesSecrets func * Mention path in the --out-prefix help * Rename --out-prefix to --out * Write script-friendly output
codingllama
added a commit
that referenced
this pull request
Jan 22, 2025
* Support multiple active CAs in `tctl auth export` * Remove the ExportAuthoritiesSecrets func * Mention path in the --out-prefix help * Rename --out-prefix to --out * Write script-friendly output
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…l#51298) * Support multiple active CAs in `tctl auth export` * Remove the ExportAuthoritiesSecrets func * Mention path in the --out-prefix help * Rename --out-prefix to --out * Write script-friendly output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add multiple active CAs support to
tctl auth exportvia the --out flag.tctl before this PR:
$ tctl auth export --type=tls-user ERROR: expected one TLS key pair, got 2tctl after this PR:
Follow up from #51189.
#35444
Changelog: Added support for multiple active CAs in
tctl auth export